Conversation
Member
|
Can you squash those patches into single one? |
cathay4t
requested changes
Mar 27, 2025
Member
cathay4t
left a comment
cathay4t
left a comment
There was a problem hiding this comment.
Except expanding the unit test for emit, all looks good to me.
| GenlHeader::parse(&GenlBuffer::new(&raw)).unwrap() | ||
| ) | ||
| .unwrap(), | ||
| ); |
Member
There was a problem hiding this comment.
Can you add assert_eq!(expected.emit(), raw)?
This covers the emit trait implementation.
Author
There was a problem hiding this comment.
I initially wasn't sure whether the header should also be emitted. I changed the test to compare the complete raw to the complete expected emitted bytes including header.
Author
There was a problem hiding this comment.
@cathay4t Is there anything else I can add or change?
arctic-alpaca
force-pushed
the
channels
branch
2 times, most recently
from
2ad1579 to
859790d
Compare
cathay4t
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR is based on @connorworley's work in #14.
I changed the function signature of
EthToolChannelSetRequest::executeto match thertnetlink::LinkSetRequest::executemethod and added examples. The issue mentioned in #14 (comment) should now be fixed by havingNLM_F_ACKfor set requests.I'm using the channel functionality to set rx and tx channels in a veth testing environment and everything seems to work as expected.